<html>
<head><meta charset="utf-8"><title>Discuss changes in  #75358 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Discuss.20changes.20in.20.20.2375358.html">Discuss changes in  #75358</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="206539221"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Discuss%20changes%20in%20%20%2375358/near/206539221" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lzutao <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Discuss.20changes.20in.20.20.2375358.html#206539221">(Aug 11 2020 at 04:30)</a>:</h4>
<p>This topic is to discuss whether we want to merge  <a href="https://github.com/rust-lang/rust/issues/75358">#75358</a>.<br>
The first perf result is kinda bad, most are regressions: <a href="https://perf.rust-lang.org/compare.html?start=13290e83a6e20f3b408d177a9d64d8cf98fe4615&amp;end=01463991259f5ad8ff520b94d9c9c2e72cdf1a98">https://perf.rust-lang.org/compare.html?start=13290e83a6e20f3b408d177a9d64d8cf98fe4615&amp;end=01463991259f5ad8ff520b94d9c9c2e72cdf1a98</a><br>
It seems that the generated code improved somehow: <a href="https://github.com/rust-lang/rust/pull/75358#issuecomment-671385849">https://github.com/rust-lang/rust/pull/75358#issuecomment-671385849</a></p>
<p>It could be my measurement error. So here we are to discuss if the measurement is correct and whether to accept this tradeoff in compile time.<br>
cc <span class="user-mention" data-user-id="116122">@simulacrum</span></p>



<a name="206562463"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Discuss%20changes%20in%20%20%2375358/near/206562463" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Discuss.20changes.20in.20.20.2375358.html#206562463">(Aug 11 2020 at 11:04)</a>:</h4>
<p>IMO, we shouldn't merge it. It seems not obvious that this is a win as it plausibly hurts the common case (non argless formatting)</p>



<a name="206568390"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Discuss%20changes%20in%20%20%2375358/near/206568390" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lzutao <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Discuss.20changes.20in.20.20.2375358.html#206568390">(Aug 11 2020 at 12:30)</a>:</h4>
<p>I don't expect we should merge it. But I want to know if you could reproduce my result.</p>



<a name="206616725"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Discuss%20changes%20in%20%20%2375358/near/206616725" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Discuss.20changes.20in.20.20.2375358.html#206616725">(Aug 11 2020 at 19:00)</a>:</h4>
<p>Which result? The gist from <a href="https://github.com/rust-lang/rust/pull/75358#issuecomment-671385849">https://github.com/rust-lang/rust/pull/75358#issuecomment-671385849</a>?</p>



<a name="206617845"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Discuss%20changes%20in%20%20%2375358/near/206617845" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Discuss.20changes.20in.20.20.2375358.html#206617845">(Aug 11 2020 at 19:10)</a>:</h4>
<p>I mean I definitely get different results with a local stage 1 build, but I don't know that that's meaningful</p>



<a name="206617868"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Discuss%20changes%20in%20%20%2375358/near/206617868" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Discuss.20changes.20in.20.20.2375358.html#206617868">(Aug 11 2020 at 19:10)</a>:</h4>
<p>I have at least debug-info and codegen-units-std=1 set</p>



<a name="206617882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Discuss%20changes%20in%20%20%2375358/near/206617882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Discuss.20changes.20in.20.20.2375358.html#206617882">(Aug 11 2020 at 19:10)</a>:</h4>
<p>and a bunch of other potential environment differences</p>



<a name="206928102"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Discuss%20changes%20in%20%20%2375358/near/206928102" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lzutao <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Discuss.20changes.20in.20.20.2375358.html#206928102">(Aug 14 2020 at 13:19)</a>:</h4>
<p>It is really weird. My system is Linux. Does Rust have different inline strategy on different OSes?</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>